Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/responsive input #209

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Feature/responsive input #209

merged 5 commits into from
Oct 8, 2024

Conversation

joh748
Copy link
Collaborator

@joh748 joh748 commented Oct 8, 2024 •
edited
Loading

  • text input box doesn't get squashed in small screens
  • I'm feeling lucky button in separate place
  • changed layout like the one below but please reject this PR if the current one is preferable
    • big screen
      image
    • small screen
      image

@joh748 joh748 added the enhancement New feature or request label Oct 8, 2024
@joh748 joh748 linked an issue Oct 8, 2024 that may be closed by this pull request
cannot see input field at the bottom on small screens #208
Closed
@joh748 joh748 marked this pull request as draft October 8, 2024 12:34
@joh748 joh748 marked this pull request as ready for review October 8, 2024 22:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

LX6T
LX6T approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@LX6T LX6T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@LX6T LX6T merged commit e08b207 into Taks0708:main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LX6T LX6T LX6T approved these changes

@Ben-G-Man Ben-G-Man Awaiting requested review from Ben-G-Man

@tom1dev tom1dev Awaiting requested review from tom1dev

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot see input field at the bottom on small screens
2 participants
@joh748 @LX6T